search

mimblewimble / grin-wallet

Grin Wallet
Apache License 2.0
182 stars 133 forks source link

Update tokio to v1 and reqwest to v0.11 #686

Open quentinlesceller opened 1 year ago

quentinlesceller commented 1 year ago

Based on the build issue we currently have on Windows. This PR update:

I'm expecting that some tests might not pass as this is a major upgrade. Locally all tests are passing.

yeastplume commented 1 year ago

Yeah, this is likely to be a major upgrade that will need attention to what's changed as well as quite a bit of testing, let's see what errors it comes back with. Note we don't need this right now cause https://github.com/mimblewimble/grin-wallet/pull/685 fixes our current issues, but we likely want to do this soon, perhaps we can do a release soon then look at this right after?

quentinlesceller commented 1 year ago

Yes absolutely. And indeed looks like #685 solved the CI issue. Agree to pause this until next release.