search

mimblewimble / grin

Minimal implementation of the Mimblewimble protocol.
https://grin.mw/
Apache License 2.0
5.04k stars 990 forks source link

Clarify wallet api commands #343

Closed andybellenie closed 6 years ago

andybellenie commented 6 years ago

I've done some work in #337 but there's still ambiguity. Based on my current PR I have:

wallet receive depreciated wallet listen operates in listening mode wallet send creates a partial transaction and writes to stdout (unchanged) wallet send -d creates a partial transaction and transmits to a potential recipient (unchanged) wallet file takes a partial transaction and completes it wallet request reserved for transactions originating at the recipient

The confusion here is that send doesn't necessarily send anything and file doesn't imply directionality

Perhaps there was no need for a new 'file' command and 'receive' should be kept as it originally was for file-based transaction competion. What do people think?

antiochp commented 6 years ago

I actually like receive for reading in from a file - think it fits with what is happening pretty nicely.

andybellenie commented 6 years ago

PR updated

ignopeverell commented 6 years ago

Fixed in #337