Allow rest api to shutdown

mimblewimble / grin

Minimal implementation of the Mimblewimble protocol.

https://grin.mw/

Apache License 2.0

5.04k stars 990 forks source link

Allow rest api to shutdown #3614

Closed i1skn closed 3 years ago

i1skn commented 3 years ago

I think we can re-enable this functionality, grin-wallet also uses this crate and it's good to have an ability to shutdown the api without killing the process.

quentinlesceller commented 3 years ago

Looking good. Do you know why we can reenable this now?

i1skn commented 3 years ago

As far as I got after conversation with @hashmap there was a temporary bug in hyper version, which is now fixed. I've tested it as a part of Ironbelly and it shutdowns the API properly.

quentinlesceller commented 3 years ago

@i1skn seems like the API does not start with this change.

i1skn commented 3 years ago

@quentinlesceller Hi, is there any specific reason or case when it does not start?

quentinlesceller commented 3 years ago

Basically any call on the API will just fail. The server is not listening.