search

mimblewimble / grin

Minimal implementation of the Mimblewimble protocol.
https://grin.mw/
Apache License 2.0
5.04k stars 990 forks source link

implement fix past fees RFC with fee shift since genesis #3629

Closed tromp closed 3 years ago

tromp commented 3 years ago

name: fixpastfees about: remove dependence of fee() and fee_shift() functions on height title: 'fix past fees' labels: '' assignees: ''

This PR implements the "fix past fees" RFC at https://github.com/mimblewimble/grin-rfcs/blob/master/text/0021-fix-prior-fees.md

It is consensus breaking in the weakest possible sense, in that older clients can disagree only if a many months deep reorg occurs that includes a > 40 bit fee (roughly 1100 Grin) prior to HF4.

This code has been tested on a sync-from-scratch. No new tests are added, and only a few were removed that used to test that> 40 bit fees were allowed prior to HF4.

phyro commented 3 years ago

We should block the merge of this one until https://github.com/mimblewimble/grin-rfcs/pull/77 is accepted

tromp commented 3 years ago

Yes, that's what it says in top description:-)

phyro commented 3 years ago

Woops, missed it. But I did mean a literal merge block by making the PR draft (WIP, DNM or similar)

antiochp commented 3 years ago

3634 updates the config file -

~accept_fee_base = 1000000~
accept_fee_base = 500000

as part of updating the config file to "version 2".

So we should be safe to include cleanup around the "rewriting" of this config item at startup in this PR.

phyro commented 3 years ago

@tromp what's the state of this one?

tromp commented 3 years ago

Ready to be merged upon approval.