search

mimblewimble / grin

Minimal implementation of the Mimblewimble protocol.
https://grin.mw/
Apache License 2.0
5.04k stars 990 forks source link

Fix Windows CI `cargo test` silently passing #3632

Closed trevyn closed 3 years ago

trevyn commented 3 years ago

I don't really know why, but the changes I made in the CI scripts for #3596 were causing the Windows CI tests to silently pass without doing anything. Changing the way the env variables are set seems to fix this, the full tests now run. grin-wallet counterpart in a moment.

Starting: Windows Cargo Test
==============================================================================
Task         : Command line
Description  : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows
Version      : 2.182.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line
==============================================================================
Generating script.
========================== Starting Command Output ===========================
"C:\Windows\system32\cmd.exe" /D /E:ON /V:OFF /S /C "CALL "D:\a\_temp\a4073cdf-5e02-40b8-8632-2b6fd7d6a3c8.cmd""
Refreshing environment variables from registry for cmd.exe. Please wait...Finished..
Finishing: Windows Cargo Test
antiochp commented 3 years ago

Good catch. I think something similar has actually bitten us in the past. I think it involves the first command returning 0 and treated as success or something similar.