Fix ROARING_ARCH environment variable

mimblewimble / grin

Minimal implementation of the Mimblewimble protocol.

https://grin.mw/

Apache License 2.0

5.04k stars 989 forks source link

Closed quentinlesceller closed 3 years ago

quentinlesceller commented 3 years ago

Good catch @antiochp :). Fixes #3641.

GeneFerneau commented 3 years ago

Does there also need to be an environment variable to disable croaring on some arches as suggested here and here?

quentinlesceller commented 3 years ago

My understanding is that with the x86-64-v2 arch, croaring will not use AVX and as such is compatible with all archs. Or did I miss something?

GeneFerneau commented 3 years ago

I just wasn't sure, saw mention of the disable env var, didn't know if it was necessary for some builds.

phyro commented 3 years ago

Should we go ahead and merge this one and prepare a new minor release? Then perhaps people at https://github.com/mimblewimble/grin/issues/3641 can give it a try

quentinlesceller commented 3 years ago

Merged! Unsure if we need a minor release for that though.