search

mimblewimble / grin

Minimal implementation of the Mimblewimble protocol.
https://grin.mw/
Apache License 2.0
5.04k stars 991 forks source link

don't confuse with different numbering bases #3660

Open tromp opened 2 years ago

tromp commented 2 years ago

Minor change in MMR doc, rewriting a few paragraphs that for no good reason used 1-based positions.

phyro commented 2 years ago

Unrelated to this change, but I do wonder if the hashing in the document is correct e.g. P = Blake2b(N | Blake2b(N | Node(p3) | Node(p2)) | Node(p1)). I don't understand why we'd hash this way.

tromp commented 2 years ago

Unrelated to this change, but I do wonder if the hashing in the document is correct e.g. P = Blake2b(N | Blake2b(N | Node(p3) | Node(p2)) | Node(p1)). I don't understand why we'd hash this way.

Thanks for spotting that mistake. Fixed now.