search

mimblewimble / grin

Minimal implementation of the Mimblewimble protocol.
https://grin.mw/
Apache License 2.0
5.04k stars 992 forks source link

The foreign_rpc and owner_rpc auto generated helper modules should be made public. #3734

Closed flomang closed 1 year ago

flomang commented 1 year ago

I've got a project that I want to build using the easy_jsonrpc_mw generated modules. In order to access those modules I need public access to the foreign_rpc and owner_rpc modules. This change shouldn't affect or require any tests nor pose any security issues.

Here is an example of client side usage that requires public access. https://github.com/flomang/grin-foreign-api-client

I also noticed the gin-wallet api is also in need of this change. I can submit a pull request for that as well if this gets approved.

yeastplume commented 1 year ago

Yes, that makes sense, I'm coming across a lot of things that 'should have been public' while doing GUI work. Will merge, and thanks for the PR.