Closed yeastplume closed 9 months ago
bitmap.remove_range_closed
became remove_range
and accepts an inclusive range as an argument, took a bit to track down. Caught by store pmmr tests. Also note this reverts the CI testing environment to the windows-2019
image as per compiler bug found in https://github.com/RoaringBitmap/croaring-rs/pull/128
Attempt to upgrade croaring-rs to 1.0.1, from 0.5.2, in an attempt to address odd instruction set issues such as found in https://github.com/mimblewimble/grin-gui/issues/73
Note this has not yet been tested, and this is here as a first pass, mostly to determine whether it does indeed address issues. A windows test was failing on the CI server at
pow::lean::test::lean_miner
. If this no longer fails after the update, this is a good sign.Issues that need to be looked into:
Bitmap
functions that take a range are required to be u32 as opposed to u64 in croaring 0.5.6. I've just cast types for now, we need to confirm this is okay.Portable
(and seems to work with existing chain data, though I could still be wrong).store
appear to be failing following this update, and we need to trace why: