serde_json 1.0.8 breaking tests (and probably grin runtime)

[antiochp]

TODO -

• [x] temporarily pin serde_json to 1.0.7 in our Cargo.toml files
• [x] investigate what broke on our end (are we making an incorrect assumption somewhere?)
• [x] ~if nothing obvious then open issue with serde_json~

serde_json just released a new version (a few hours ago) and its breaking tests (failing on TravisCI and locally).

https://github.com/serde-rs/json/releases

cargo test -p grin_keychain
 Downloading serde_json v1.0.8
   Compiling serde_json v1.0.8
   Compiling secp256k1zkp v0.7.1 (https://github.com/mimblewimble/rust-secp256k1-zkp?tag=grin_integration_1#a3257cee)
   Compiling grin_util v0.1.0 (file:///antiochp/grin/util)
   Compiling grin_keychain v0.1.0 (file:///antiochp/grin/keychain)
warning: unused `#[macro_use]` import
  --> keychain/src/lib.rs:22:1
   |
22 | #[macro_use]
   | ^^^^^^^^^^^^
   |
   = note: #[warn(unused_imports)] on by default

    Finished dev [unoptimized + debuginfo] target(s) in 7.21 secs
     Running target/debug/deps/grin_keychain-15cde2f5b166befd

running 5 tests
test extkey::test::test_identifier_json_ser_deser ... FAILED
test extkey::test::extkey_derivation ... ok
test extkey::test::extkey_from_seed ... ok
test keychain::test::test_key_derivation ... ok
test keychain::test::test_rewind_range_proof ... ok

failures:

---- extkey::test::test_identifier_json_ser_deser stdout ----
    thread 'extkey::test::test_identifier_json_ser_deser' panicked at 'called `Result::unwrap()` on an `Err` value: ErrorImpl { code: Message("invalid type: string \"942b6c0bd43bdcb24f3e\", expected an identifier"), line: 1, column: 36 }', src/libcore/result.rs:906:4
note: Run with `RUST_BACKTRACE=1` for a backtrace.

[ignopeverell]

Should we set the version to 1.0.7 for now?

[sesam]

Suggest yes, and to report this upstream that a minor version upgrade seems to have "hardforked" their API.

On Sat, Dec 9, 2017, 01:11 Ignotus Peverell notifications@github.com wrote:

Should we set the version to 1.0.7 for now?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mimblewimble/grin/issues/450#issuecomment-350404204, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAi2dJa-AlMuSvo-xA7aIKorAFdXNe_ks5s-dBLgaJpZM4Q7x_N .