mimblewimble / grin

Minimal implementation of the Mimblewimble protocol.
https://grin.mw/
Apache License 2.0
5.04k stars 991 forks source link

Internal Renaming due to Storage Changes #723

Closed yeastplume closed 6 years ago

yeastplume commented 6 years ago

After https://github.com/mimblewimble/grin/pull/702, PMMRTrees aren't sumtrees anymore, they're PMMR trees that store hashes, and the tree's node indexing optionally references data in flat storage files.. many variables and structure names which currently reference sumtrees should be renamed for clarity. Before this can happen, we need to decide on what names we're going to use for things.

There are probably a couple more if anyone can think of any. If we can solidify this here I can go make the changes (which more annoying than you'd realise due to the number of references in the code and comments).

ignopeverell commented 6 years ago

I'm good with Hashtrees. I was thinking of leaving PMMR as an implementation detail.

TXOSet is a little ambiguous, as it usually means transaction Ouputs. How about TxHashSet? I agree for output_pmmr.