search

mimblewimble / grin

Minimal implementation of the Mimblewimble protocol.
https://grin.mw/
Apache License 2.0
5.04k stars 991 forks source link

starting mining node up with no running wallet is no longer working (regression?) #768

Closed antiochp closed 6 years ago

antiochp commented 6 years ago 
Mar 13 16:01:30.642 ERRO Failed to get coinbase from http://127.0.0.1:13415/v1/receive/coinbase. Run grin wallet listen
Mar 13 16:01:30.643 ERRO Successfully received coinbase from http://127.0.0.1:13415/v1/receive/coinbase
thread 'miner' panicked at 'cannot recursively call into `Core`', src/libcore/option.rs:891:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.

We used to loop and wait for the wallet to start (polling for it with a backoff).

Not had time to investigate further so opening issue so we don't forget about this.

yeastplume commented 6 years ago

@ignopeverell made a sneaky commit here to do with automatically running wallet listeners if desired https://github.com/mimblewimble/grin/commit/a8fcc37a364059248a87198162dc3563e79f547b Will have a look into it now

yeastplume commented 6 years ago

Probably fixed by https://github.com/mimblewimble/grin/pull/774 along with a few other things, but I never saw that particular panic at any point. Can you check again once I've merged that one?

ignopeverell commented 6 years ago

Yeah, sorry for the sneakiness, bad case of PR laziness. Still not sure what would have caused the above though, the listener only panics without a seed, and should have asked for one.

antiochp commented 6 years ago

I can take another look. Definitely had a seed file in place - I just forgot to start the wallet listener first.