mimblewimble / grin

Minimal implementation of the Mimblewimble protocol.
https://grin.mw/
Apache License 2.0
5.04k stars 991 forks source link

Compiling without miner doesn't work #961

Closed chri2 closed 6 years ago

chri2 commented 6 years ago

In ./pow/Cargo.toml:

[dependencies.cuckoo_miner]
features=["no-plugin-build"]

according to https://github.com/mimblewimble/grin/blob/master/doc/build.md#building-the-cuckoo-miner-plugins leads to:

error[E0463]: can't find crate for `pow`
  --> src/bin/tui/mod.rs:17:1
   |
17 | extern crate grin_pow as pow;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to previous error

error: Could not compile `grin`.

To learn more, run the command again with --verbose.
chri2 commented 6 years ago

With these changes grin compiled without miner:

[root@rpi3 grin]# diff src/bin/tui/mod.rs.orig src/bin/tui/mod.rs
17c17
< extern crate grin_pow as pow;
---
> // extern crate grin_pow as pow;
25c25
< mod mining;
---
> // mod mining;
[root@rpi3 grin]# diff src/bin/tui/ui.rs.orig src/bin/tui/ui.rs
33c33,34
< use tui::{menu, mining, peers, status, version};
---
> // use tui::{menu, mining, peers, status, version};
> use tui::{menu, peers, status, version};
71c72
<       let mining_view = mining::TUIMiningView::create();
---
>       // let mining_view = mining::TUIMiningView::create();
79c80
<           .layer(mining_view)
---
> //            .layer(mining_view)
127c128
<                   mining::TUIMiningView::update(&mut self.cursive, &update);
---
> //                    mining::TUIMiningView::update(&mut self.cursive, &update);
yeastplume commented 6 years ago

Should be a non-issue now, (grin no longer compiles mining plugins:) https://github.com/mimblewimble/grin/pull/979