search

mimblewimble / grin

Minimal implementation of the Mimblewimble protocol.
https://grin.mw/
Apache License 2.0
5.04k stars 991 forks source link

Do we need to still validate Odd Fee? #968

Closed zman0225 closed 6 years ago

zman0225 commented 6 years ago

If I'm understanding the arch properly, isn't the OddFee restriction due to burning? (which has been recently removed here: #767

https://github.com/mimblewimble/grin/blob/cc9ffcc1ab784be22e8fce2ae5b32e5c4b8bc500/core/src/core/transaction.rs#L423-L425

antiochp commented 6 years ago

I believe this is no longer necessary. Want to open a PR to remove this check (and cleanup the OddFee error itself)? There may or may not be test coverage around this that would need cleaning up also.

antiochp commented 6 years ago

Closing - resolved in #975.