Closed garyyu closed 6 years ago
I think if we hold to the "one pull-request solve one problem" (which I personally think is a good idea), then it is important to also maintain a full passing test suite against each PR. The unit of work here would be the code "solving the problem" and the associated test changes.
We should aim to avoid putting the master branch in a "broken" state, even temporarily.
Indeed, the progress on the current issue looks great, but all you need to do is open up a WIP issue against T3 for now.. that should be enough to let us review/discuss until it’s ready for merge
This is the preparation before giving the pull request for range proof batch verification and so on.
Better switching to master branch to do those things, related submodule pr: https://github.com/mimblewimble/secp256k1-zkp/pull/19 , please accept it in both sides.
Based on rule
one pull-request solve one problem
, there could be multiple pull-requests after this pr.