derive Serialize and Deserialize for error

mimblewimble / rust-secp256k1-zkp

ZKP fork for rust-secp256k1, adds wrappers for range proofs, pedersen commitments, etc

Creative Commons Zero v1.0 Universal

56 stars 51 forks source link

derive Serialize and Deserialize for error #44

Closed bddap closed 5 years ago

bddap commented 5 years ago

This pr makes secp256k1-zkp::Error serializable and deserializable. The change is required so that grin api v2 can use structured error types.

yeastplume commented 5 years ago

Looks good, there might be a few more instances of this in the secp code where a serialise is required.

Just as an aside, if you're working on wallet code it's all being moved to https://github.com/mimblewimble/grin-wallet. (We'd also encourage PRing early and often so everyone else has some visibility on what you're working on.)