mimblewimble / rust-secp256k1-zkp

ZKP fork for rust-secp256k1, adds wrappers for range proofs, pedersen commitments, etc
Creative Commons Zero v1.0 Universal
56 stars 51 forks source link

Update azure to use latest, fix warnings #66

Closed yeastplume closed 4 years ago

yeastplume commented 4 years ago

Further update to CI settings and fix for warnings:

quentinlesceller commented 4 years ago

Since rustup is installed you need to add:

macOS and Linux:

rustup toolchain install $RUSTUP_TOOLCHAIN
rustup default $RUSTUP_TOOLCHAIN

and Windows:

rustup toolchain install %RUSTUP_TOOLCHAIN%
rustup default %RUSTUP_TOOLCHAIN%
quentinlesceller commented 4 years ago

It looks like Rustup is not included in Windows Server 2019 (https://github.com/actions/virtual-environments/blob/master/images/win/Windows2019-Readme.md). You might want to try the above. Otherwise you need to add:

    - script: |
         curl -sSf -o rustup-init.exe https://win.rustup.rs
         rustup-init.exe -y --default-toolchain %RUSTUP_TOOLCHAIN%
       displayName: Install Rust
yeastplume commented 4 years ago

Unfortunately on windows that brings us right back to the original issue:

https://dev.azure.com/mimblewimble/rust-secp256k1-zkp/_build/results?buildId=1653&view=logs&j=57b2b475-8d2a-5b04-5d48-0e52fa3a6ad3&t=5ecf445a-2f64-5417-8d77-bb5b450b5bee

quentinlesceller commented 4 years ago

@yeastplume can you try this on Windows:

rustup-init.exe toolchain install  %RUSTUP_TOOLCHAIN%
rustup-init.exe default %RUSTUP_TOOLCHAIN%

and remove this line:

rustup-init.exe -y --default-toolchain %RUSTUP_TOOLCHAIN%
quentinlesceller commented 4 years ago

Wondering if this is necessary to export again the Cargo path on Windows (echo "##vso[task.setvariable variable=PATH;]%PATH%;%USERPROFILE%\.cargo\bin"). Not sure which one Windows is using. Or simply try to display the toolchain before cargo to be sure.

quentinlesceller commented 4 years ago

Found the reason https://github.com/rust-lang/rustup/issues/2203