Closed antiochp closed 6 years ago
For now I can just merge both at the same time. When we have a release out, we can start worrying about backward compatibility and versioning. Is this ready for review?
Yeah - these should both be ready to go. I've tested grin locally pointing at my forked version of rust-secp256k1-zkp and everything looks good. But there's always a chance I missed something with the dependencies.
The PR does the following -
1) exposes msg as a param to
range_proof
1) uses thesecret_key
as the nonce inrange_proof
1) allows the same secret key to be passed in as the nonce inrewind_range_proof
1) introduces a newMessageProof
struct so we can conveniently interact with the msg itself 1) also fixes running the tests in travis (cargo command was broken from earlier)This lets us rewind a range_proof to recover both the original value and original message from the proof.
If someone with more knowledge of the underlying secp lib could confirm (2) is safe to do that would be much appreciated.
This resolves issue #7.
Note: this is a breaking change to the secp api and will break Grin (the msg param is new). The corresponding PR on the grin side is here - ignopeverell/grin#155.
What's the process here - do we get away with merging these 2 related PRs together - or do we want to manage backward compatibility across these 2 repos somehow? One option may be to tag
rust-secp256k1-zkp
and specify the tag in Cargo.toml in Grin prior to merging this?