search

mimblewimble / secp256k1-zkp

Fork of secp256k1-zkp for the Grin/MimbleWimble project
MIT License
32 stars 42 forks source link

minor fix: clean build warnings #20

Closed garyyu closed 6 years ago

garyyu commented 6 years ago

There're several boring warnings, clean them firstly:)

I have to do several git cherry-pick from my master branch, so perhaps look like multiple commits.

yeastplume commented 6 years ago

We don't actually mess with any of these functions ourselves... these changes really belong upstream and I'd rather change them for the sake of a few warnings to ensure that merges from upstream remain as painless as possible.

If you'd like to suggest the same changes upstream to https://github.com/ElementsProject/secp256k1-zkp they might want to merge them in there.

garyyu commented 6 years ago

@yeastplume could you please confirm that's the correct upstream? because I didn't find the whole folder src/modules/bulletproofs at that repo.

yeastplume commented 6 years ago

That part is still in an active PR: https://github.com/ElementsProject/secp256k1-zkp/pull/23