Multi-party bulletproof

mimblewimble / secp256k1-zkp

Fork of secp256k1-zkp for the Grin/MimbleWimble project

MIT License

32 stars 42 forks source link

Multi-party bulletproof #24

Closed jaspervdm closed 5 years ago

jaspervdm commented 6 years ago

Add support for creating bulletproofs with multiple parties.

[x] Figure out if we can simplify the 3 new BP methods, since they contain a lot of the same code as the original
[x] Add documentation of arguments
[x] Tests

Here is a short explanation of how to create a multi-party BP: https://i.imgur.com/s7exNSf.png

yeastplume commented 5 years ago

I think that looks good for the time being. It's probably possible to refactor somewhat to make the API cleaner, but since the upstream implementation is still in development I'd rather we kept as close to that as possible to avoid merge headaches. So all good by me.

And thanks for fixing the tests, just realised I forgot to do that on the C side when I added the message

jaspervdm commented 5 years ago

The tests succesfully generate and verify 2 to 10 party proofs, so this is in my opinion now ready to be merged in.

yeastplume commented 5 years ago

:+1: