Add blinding factor for switch commitment

mimblewimble / secp256k1-zkp

Fork of secp256k1-zkp for the Grin/MimbleWimble project

MIT License

32 stars 42 forks source link

Add blinding factor for switch commitment #34

Closed jaspervdm closed 5 years ago

jaspervdm commented 5 years ago

Calculates the modified blinding factor x + H(xG+vH | xJ). Relevant grin PR: https://github.com/mimblewimble/grin/pull/2157

jaspervdm commented 5 years ago

@garyyu I changed it to use pubkeys instead of raw bytes, what do you think?

yeastplume commented 5 years ago

Fine with the addition at this level in the code, and up to you whether you want to adopt @garyyu style/naming suggestions. You may just want to add a test or two (I'd usually put one or two in at this layer, ensure they pass and ensure compilation has no warnings.

jaspervdm commented 5 years ago

I think this is ready to be merged in!

yeastplume commented 5 years ago

Okay, great. I'll merge now, have a look over it locally, and tag