mimblewimble / secp256k1-zkp

Fork of secp256k1-zkp for the Grin/MimbleWimble project
MIT License
32 stars 43 forks source link

generator problems #4

Closed antiochp closed 7 years ago

antiochp commented 7 years ago

The following is called in the various range proof functions -

secp256k1_generator_load(&genp, gen);

We're not passing in gen from Grin (via rust-secp256k1-zkp) and it is not clear to me what we need to be doing here.

antiochp commented 7 years ago

Actually looks like the code relies on gen as input param in these functions -

And from the comments in include/secp256k1_rangeproof.h -

 gen:        additional generator 'h'
antiochp commented 7 years ago

This (I believe) is fixed - we pass in a gen via grin code now.