mimblewimble / secp256k1-zkp

Fork of secp256k1-zkp for the Grin/MimbleWimble project
MIT License
32 stars 42 forks source link

fix the test commitment #43

Closed garyyu closed 5 years ago

garyyu commented 5 years ago

The secp256k1_pedersen_commit api doesn't really use the ctx parameter (anything with not null is ok for it), so whatever we use (none, vrfy, or sign) the result will be same.

According to the discussion on upstream: https://github.com/ElementsProject/secp256k1-zkp/pull/23/files#r242390153, the 'ctx' parameter here is just

For reasons of API consistency we prefer to have the context object in every public-facing function.

So, let's fix it by ourselves to prepare for enabling the Travis-CI for this repo.