mimblewimble / secp256k1-zkp

Fork of secp256k1-zkp for the Grin/MimbleWimble project
MIT License
32 stars 42 forks source link

distcheck build fail #45

Open garyyu opened 5 years ago

garyyu commented 5 years ago

One of building job: BUILD=distcheck will fail.

$ make  dist-gzip am__post_remove_distdir='@:'
make: *** No rule to make target 'src/bench_aggsig.c', needed by 'distdir'.  Stop.

Before we find a fix on the Makefile for this, I have to disable it to let all remaining 38 building jobs works for Travis-CI.

How to produce? You can run the following script on Linux:

#!/bin/sh

export FIELD=auto
export BIGNUM=auto
export SCALAR=auto
export ENDOMORPHISM=no
export STATICPRECOMPUTATION=yes
export ASM=no
export BUILD=check
export EXTRAFLAGS=
export HOST=
export ECDH=no
export RECOVERY=no
export EXPERIMENTAL=no
export JNI=no
export GUAVA_URL=https://search.maven.org/remotecontent?filepath=com/google/guava/guava/18.0/guava-18.0.jar
export GUAVA_JAR=src/java/guava/guava-18.0.jar
export BUILD=distcheck
export TRAVIS_COMPILER=gcc
export CC=gcc
export CC_FOR_BUILD=gcc
export CASHER_DIR=${TRAVIS_HOME}/.casher
gcc --version
mkdir -p `dirname $GUAVA_JAR`
if [ ! -f $GUAVA_JAR ]; then wget $GUAVA_URL -O $GUAVA_JAR; fi
# ./autogen.sh
if [ -n "$HOST" ]; then export USE_HOST="--host=$HOST"; fi
if [ "x$HOST" = "xi686-linux-gnu" ]; then export CC="$CC -m32"; fi
./configure --enable-experimental=$EXPERIMENTAL --enable-endomorphism=$ENDOMORPHISM --with-field=$FIELD --with-bignum=$BIGNUM --with-scalar=$SCALAR --enable-ecmult-static-precomputation=$STATICPRECOMPUTATION --enable-module-ecdh=$ECDH --enable-module-recovery=$RECOVERY --enable-module-generator=$GENERATOR --enable-module-commitment=$COMMITMENT --enable-module-rangeproof=$RANGEPROOF --enable-module-bulletproof=$BULLETPROOF --enable-module-whitelist=$WHITELIST --enable-module-surjectionproof=$SURJECTIONPROOF --enable-jni=$JNI $EXTRAFLAGS $USE_HOST && make -j2 $BUILD
jaspervdm commented 5 years ago

This is expected, as there are no benchmarks written for the aggsig module. It is a custom module by yeastplume that he based on some other code (not sure exactly which one). So we can just remove these lines from the Makefile: Makefile.am.include:L4-8