Pre-allocated contexts - Githubissues

mimblewimble / secp256k1-zkp

Fork of secp256k1-zkp for the Grin/MimbleWimble project

MIT License

32 stars 42 forks source link

Pre-allocated contexts #61

Closed DavidBurkett closed 3 years ago

DavidBurkett commented 3 years ago

Please review carefully. The tests all passed, and I manually reviewed twice. But this stuff is dense, so it's easy to miss things. Having extra sets of eyes on it would give me greater confidence in the changes.

GeneFerneau commented 3 years ago

Code review and test ACK.

Ran tests with and without static ecmult_gen, and using clang's ASAN sanitizer.

A number of memory leaks are detected in the tests, probably unrelated to this PR. Still debugging the sources of the leaks.

No detection of access to unallocated memory.

Can run the tests with ASAN using ./configure --enable-asan ... and the changes in #62.

DavidBurkett commented 3 years ago

Closing in favor of: https://github.com/mimblewimble/secp256k1-zkp/pull/63