search

mimblewimble / secp256k1-zkp

Fork of secp256k1-zkp for the Grin/MimbleWimble project
MIT License
32 stars 42 forks source link

Signature Subtraction function #67

Closed yeastplume closed 1 year ago

yeastplume commented 1 year ago

WIP - Due to ambiguity around nonce y-coordinates, the current version returns two separate possible signatures in some cases (both of which much be tried for the purposes of payment proofs.

Debugging output left in for the moment, to run this test only you may want to comment or def out everything in src/tests.c other than run_aggsig_tests()

yeastplume commented 1 year ago

relevant keybase conversation starts here: keybase://chat/grincoin.teams.node_dev#general/8880

yeastplume commented 1 year ago

This is ready for review now. Note that I opted to have a single function that returns whether the caller needs to check the second value to verify. This works well with the rust side, which can just return an tuple containing a result and an optional second possible result only if needed.