search

mimbrero / whatsapp-desktop-linux

Unofficial WhatsApp Linux client built with Electron.
https://flathub.org/apps/details/io.github.mimbrero.WhatsAppDesktop
MIT License
83 stars 21 forks source link

Multiple tray icons #10

Closed atomicptr closed 2 years ago

atomicptr commented 2 years ago

For some odd reason this app creates a second tray icon after a while.

image

You can close the app with either and the other one will disappear as well. An easy way to reproduce this issue instantly on GNOME at least is to start the app and then restart gnome-shell via Alt+F2 > r > Enter.

Fedora 35 with GNOME 41.4

mimbrero commented 2 years ago

The icon with no image seems to be a KStatusNotifierItem, while the other is the GTK2 one. This is probably a Flatpak issue. Will investigate this soon to only use the KDE one but you can see that the icon never loads and it shows those dots :)

mimbrero commented 2 years ago

Ok, this is a Flatpak issue.

But I could use the KStatusNotifierItem solution just in the flatpak build, like Discord does. It is better in all ways, it displays a shell menu, not a GTK2 legacy one, that doesn't show up in the activities menu for example.

GTK2:

KStatusNotifierItem:

But first I have to solve the icon issue first. I can't find ANY information about it. Why doesn't the image display and what are those three dots??

mimbrero commented 2 years ago

Maybe @hfiguiere can help? He is who accepted my flathub submission.

hfiguiere commented 2 years ago

I just reviewed it. Nothing more.

mimbrero commented 2 years ago

I just reviewed it. Nothing more.

Sorry, I was wondering if you knew anything about this KStatusNotifierItem bug, or could tell me who to contact with. You are the only person I had contact with in the Linux dev community :)

filipepcapulo commented 2 years ago

Hello. I'd like to give a suggestion about this new tool. For me the tray icon isn't necessary, so i guess you could create a way to disable it like other proprietary software as Telegram. And i thank you for the good work.

mimbrero commented 2 years ago

Hello. I'd like to give a suggestion about this new tool. For me the tray icon isn't necessary, so i guess you could create a way to disable it like other proprietary software as Telegram. And i thank you for the good work.

The close icon will actually quit the application for the next release (when someone wants to minimize it to tray, they will just use the menu option)

If you mean that you don't want to see the icon in your tray, I don't know how to implement that because, as I can't change the original web.whatsapp.com code, I can't add custom settings to the app (and making another settings window would be weird for the user) :(

mimbrero commented 2 years ago

@atomicptr I've been testing something and I'm going to use a custom static icon with a red dot instead of getting the favicon. That would allow me to export the image in the Flatpak build and use the KStatusNotifierItem solution