mimbrero / whatsapp-desktop-linux

Unofficial WhatsApp Linux client built with Electron.
https://flathub.org/apps/details/io.github.mimbrero.WhatsAppDesktop
MIT License
78 stars 20 forks source link

[feature request] Full viewport for large aspect ratio screens. #21

Open CleoMenezesJr opened 2 years ago

CleoMenezesJr commented 2 years ago

Hi, very cool project. Only from my cents of trying to contribute as I would like to help without time to help with something really relevant. For some high aspect ratio screens, WhatsApp Web does not track the viewport fill. Create this extension for Firefox to enable this.

It would be interesting something like this to fill the entire apply screen.

mimbrero commented 2 years ago

I don't know how this would affect the project. That would be modifying the official WhatsApp CSS and would give Meta (Facebook) reasons to take this down, like what happened with other projects. Another thing is that the CSS, like the JS, is obfuscated, so depending on something that can be automatically renamed at any time isn't very safe...

Anyways, if the official Desktop app does that on Windows and MacOS (please tell me because I don't know) I'll look into it and do it.

CleoMenezesJr commented 2 years ago

Well, your app is a web view, what I basically propose is not a hack in their CSS or JavaScript, what I do is assign an ID to the viewport element and say that this element has to fill the entire viewport. All the code is there in my repository, and you can verify that I don't do anything other than on the client side.

mimbrero commented 2 years ago

Well, I've been thinking and this wouldn't affect the company, like limiting or changing the JS code would. Facebook took down lots of repos for "having a negative impact on the company" or something like that, like APIs or unofficial desktop apps (for Windows and MacOS).

I admit that if the official app has for example trackers, unofficial apps for Windows and MacOS negatively affect Meta, but this repo is for Linux only and changing the CSS is literally nothing for them.

I'm going to add this for the 1.3 release :)