mime-types / ruby-mime-types

Ruby MIME type registry library
Other
324 stars 122 forks source link

Hardcode common argument results to prevent dup string allocations #135

Closed dillonwelch closed 6 years ago

jeremyevans commented 6 years ago

This looks fine to me, but you should probably remove the changes to the gemspec. That file should actually be deleted since I think Hoe is now used in the Rakefile to create the gemspec.

dillonwelch commented 6 years ago

Updated!

halostatue commented 6 years ago

The gemspec is committed so that git-bundled uses of mime-types works, and the Gemfile specifies gemspec. It’s been a while, but if you install the necessary dependencies, it should be possible to type rake gemspec and it should automatically generate/update the .gemspec file.

halostatue commented 6 years ago

Normally, I do this as part of release hygiene.

dillonwelch commented 6 years ago

I can clean up all of the .freeze in the gemspec file too if you'd like

halostatue commented 6 years ago

The gemspec is generated. If the .freeze methods are there, they get left there.