search

mime-types / ruby-mime-types

Ruby MIME type registry library
Other
324 stars 122 forks source link

Change "...is already registered as a variant..." message to `DEBUG` level #170

Closed dogweather closed 1 year ago

dogweather commented 1 year ago

A simpler way to solve https://github.com/mime-types/mime-types-data/pull/50.

IMO the problem is, the library shows a warning message to the wrong audience (application developers). It's not understandable to app devs, not marked with its provenance (source lib name), and finally, app devs have no way to resolve it.

Instead, the message seems aimed at mime-types-data library developers.

This PR sends the message to the proper audience by using the DEBUG log level.

This change is Reviewable

halostatue commented 1 year ago

The tests are failing for unknown reasons at this point (although the Ruby 2.5 failure appears to be consistent).

halostatue commented 1 year ago

Hi, @dogweather.

I’m still in favour of this if you wanted to finalize it. It will be less urgent as of tonight because I will be releasing a mime-types-data update based on mime-types/ruby-mime-types#53.

In order to get it merged, I’ll need you to rebase this so that there are no merge commits and a single commit, but the one line change here is still a good one.

halostatue commented 1 year ago

You will also want to rebase your branch — I have some updates to CI which will improve the test results.