Fix headers includes and namespaces to follow changes in SOFA

mimesis-inria / caribou

Multi-physics computation library

GNU Lesser General Public License v3.0

29 stars 17 forks source link

Fix headers includes and namespaces to follow changes in SOFA #140

Closed epernod closed 1 year ago

epernod commented 1 year ago

Fix v22.06 based on #137 (sorry I can't edit the PR)
Fix compatibility with previous version (I'm not sure this is a good idea)

hugtalbot commented 1 year ago

Sorry @epernod I hijacked your PR to fix the configuration for benchmarks using sofa_find_package macro Else :+1: works for me!

jnbrunet commented 1 year ago

Thanks @epernod !! Looks like it fails with master. I can try to have a look this evening (Montreal time).

Fix compatibility with previous version (I'm not sure this is a good idea)

I completely agree. What we could do is, fix all versions with your PR, then make one branch and tag per version, and then drop the support for different versions in the master branch.

jnbrunet commented 1 year ago

Still some issues with the getTemplateName() that is now final. I will try to fix it tomorrow.

epernod commented 1 year ago

mi PR es tu PR.... !

jnbrunet commented 1 year ago

mi PR es tu PR.... !

Yeah sorry about that, I really just hijack your PR :)

Almost there... I will have to dig up my old dusty macbook for this one I believe...

hugtalbot commented 1 year ago

It looks like my commit is not appreciated on MacOS ..

-- Caribou with benchmarks
  Unknown CMake command "sofa_find_package".

-- Configuring incomplete, errors occurred!
See also "/Users/runner/work/caribou/caribou/CMakeFiles/CMakeOutput.log".