search

mimesis-inria / caribou

Multi-physics computation library
GNU Lesser General Public License v3.0
29 stars 17 forks source link

Fix for Sofa.linearalgebra (master) #64

Closed fredroy closed 3 years ago

fredroy commented 3 years ago

collision with fwd declarations.

fredroy commented 3 years ago

D'oh, it only works on mac/master (and windows/master 😛) back to wip...

hugtalbot commented 3 years ago

It works on my end :+1:

fredroy commented 3 years ago

Just noticed that the CI is not taken the latest version of binaries for master ...

jnbrunet commented 3 years ago

Hey @fredroy , thanks for this PR. Not sure why it isn't taking latest SOFA files. Did the CI's nightly job url for linux changed? It is currently set to the following:

https://ci.inria.fr/sofa-ci-dev/job/nightly-generate-binaries/lastStableBuild/CI_BRANCH=master,CI_SCOPE=standard/artifact/Linux/*zip*/Linux.zip

fredroy commented 3 years ago

Hey @fredroy , thanks for this PR. Not sure why it isn't taking latest SOFA files. Did the CI's nightly job url for linux changed? It is currently set to the following:

Yes, URLs changed (after speaking with @guparan); AND the CI for Sofa has changed as well and is compiling linux builds with ubuntu 2004.(so a new gcc and a new glibc apparently) If you compile any plugin with ubuntu 1804, and using a SOFA compiled with 2004, it will fail at link time because of the glibc change 🤪 I am playing a bit with github actions on my fork, you can see my sandbox: https://github.com/fredroy/caribou/pull/1 I've changed the docker container (inspired by your dockerfile actually...) and the url. It seems to compile, except that the "compatiblity" layer seems not detected (?)

jnbrunet commented 3 years ago

Ok I see. So let's first fix the workflow. Did ubuntu 20.04 was used for the 21.06 release? If not, will it be used for patches (21.06.01+) ?

It would be great to have a precise list of the dependencies and build tools used for SOFA release and nightly generated binaries. Especially if we want to generate binaries that user can simply drag and drop into the plugin directory.

jnbrunet commented 3 years ago

Its getting late here, and I still didn't have time to look at this,. I'll try to do it (fix the master link and the 20.04 builder docker image) this weekend.