Default Parameters Improvements

[lrennels]

FROM FUND INTEGRATION BRANCH COMMENT by @ckingdon95

I went through and added default parameter values for each component, however I only did this for scalar values and 1-D vectors. Parameters that are two dimensional (either time x regions, or regions x regions) still get loaded from files. I moved all of the data files into "old_data" for now, and now the "data" folder only holds the needed 2-D parameters.

A couple questions for us to think about:

• Do we want to handle the 2-D parameters differently? (i.e. a universal Mimi function for loading in parameters in long format from CSVs?)
• For 1-D vector parameters (that have 16 values, one for each region), the way they get set here assumes implicit ordering of the regions. Do we want this to be different? Should we support syntax in the defcomp macros like the way we support regional labeling in the defmcs macros?
• Some parameter values (such as gdp90 and pop90) get used by several different components. The way I've done it here is that each component assigns them the same default values. This feels redundant, and possibly buggy. Would it be better to not set these "shared" parameters in every component, but instead set them in the model, then set_leftover_params would get each component to pick up the value?
• related: I checked that if two different components set a default parameter by the same name but with a different value, then the value of the later component overrides the previously defined value.

[lrennels]

@davidanthoff @rjplevin I've added this issue using notes from @ckingdon95 from her latest addition to fund::integration.

[lrennels]

@davidanthoff @ckingdon95 pinging this as an issue to check for potentially breaking behavior, I think it's fine as v1.1.0 but worth checking!

[davidanthoff]

Agreed, I think we can move this to a later milestone.