codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 100.00% and no project coverage change.
Comparison is base (
6ea9074) 84.83% compared to head (7e4b216) 84.83%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #968 +/- ## ======================================= Coverage 84.83% 84.83% ======================================= Files 40 40 Lines 4055 4055 ======================================= Hits 3440 3440 Misses 615 615 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `84.83% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mimiframework#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/mimiframework/Mimi.jl/pull/968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mimiframework) | Coverage Δ | | |---|---|---| | [src/utils/getdataframe.jl](https://app.codecov.io/gh/mimiframework/Mimi.jl/pull/968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mimiframework#diff-c3JjL3V0aWxzL2dldGRhdGFmcmFtZS5qbA==) | `77.41% <100.00%> (ø)` | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
davidanthoff
There are two commits here that are unrelated.
The one about the
deepcopyI'm especially not 100% sure. But I think I followed all code paths, and I think previously the deep copy that was created originally was then actually never (except for the one case where I added adeepcopyreturned to user, but was essentially always a temporary copy, in which case it seems unnecessary to me.