search

mimimi / ruby-tsv

Simple TSV parser
MIT License
37 stars 4 forks source link

Cyclist improvements #4

Closed Slotos closed 9 years ago

Slotos commented 9 years ago

Yeah, I'm leaning towards ditching Cyclist inheritance idea. The initial idea was to provide easy way to extend the functionality, but it doesn't seem to be solving a real world problem. Incidentally it's possible to imitate ruby core CSV naming, since it solves almost the same problem.

#with_header and #withour_header can be simplified, but removing them doesn't change neither operational nor code complexity. As such I'd prefer leaving them in place.

I'll get on with cutting out Cyclist inheritance then. One elephant at a time.

Slotos commented 9 years ago

Unexpected bonus from this refactor job: I could ditch the test that needed five lines of comments to make sense.

Oh, it's not ready for merge yet. Readme has to be updated first.

Slotos commented 9 years ago

A bit of a late consideration. TSV::Table is also a misleading name, since we don't really provide a table, but an Enumerator wrapper. Though its intent is still clearer.

brain-geek commented 9 years ago

I love those new improvements.

If we won't have anymore ideas/PRs then I'll release this version on Rubygems in a few days.