search

mimoguz / tripeaks-gdx

A simple tri peaks solitaire game using libGDX.
GNU General Public License v3.0
68 stars 8 forks source link

Auto dark theme on Android #26

Closed jjrpayne closed 4 days ago

jjrpayne commented 7 months ago

An option to auto-select the dark theme based on the user's system settings would be a nice feature.

mimoguz commented 7 months ago

Hi. I'm not sure if libgdx has an api for querying system theme, but I can add this to my to-do list for my rewrite, that is unfortunately long interrupted due to multiple consecutive health issues. I'll need to redesign the options dialog anyway.

jjrpayne commented 7 months ago

I'd be interested in implementing this if I may contribute. I imagine it should be possible to pass the system theme through the Android launcher if an API query doesn't exist.

mimoguz commented 2 weeks ago

A draft implementation on the system_theme branch.

mimoguz commented 1 week ago

Asking for opinions: issue #27

JVariance commented 1 week ago

An improvement would be to select the black theme as dark theme, not as an extra option, so the theme would still be dynamic (light/black).

mimoguz commented 1 week ago

I don’t know. I don’t want to remove the ‘regular’ dark theme or overcrowd the options dialog. I’ve actually considered adding a fifth option, like 'system with black' or something, but four options already fill the entire height of the dialog 🙂.

mimoguz commented 4 days ago

Included in the 1.2.0 release.