mimoguz / tripeaks-gdx

A simple tri peaks solitaire game using libGDX.
GNU General Public License v3.0
68 stars 8 forks source link

Card flip bugs #6

Closed peterbabic closed 3 years ago

peterbabic commented 3 years ago

Hello, the game is nice but there are some issues, screenshots below.

Hearts 10 flipped top left: Screenshot_20210503-215503 Top left card not flipped: Screenshot_20210503-223411 Two entry row cards not flipped: Screenshot_20210505-025025 One entry row card not flipped: Screenshot_20210505-025603 Black 5 flipped in the middle, but should not be: Screenshot_20210505-025643 Red 2 flipped in the middle: Screenshot_20210505-025838 The same red 2 even disappeared: Screenshot_20210505-025853

mimoguz commented 3 years ago

Uh, weird. Can you check which version you have? I play it every day, never saw something like that since version 0.1. Button graphics say it's a later version though :( Can you try purging and re-installing, just in case?

mimoguz commented 3 years ago

Also, which version of Android do you have?

peterbabic commented 3 years ago

@mimoguz I have version 0.44 installed via F-Droid on Android 9.

Most of the bugs seem to be related to a situation when there is the same card twice. Can you please confirm/reject that it shouldn't be possible? I believe all cards on the desk should be unique. When due to some unknown reason the same card gets on the different positions, the problems occur.

I have purged the game but had not played it yet since.

mimoguz commented 3 years ago

All cards must be unique. Game logic is pretty simple, and there should be nothing that can cause this behaviour. Previous issue was just a stupid mistake with indexes when checking neighbours. I'll try running in Android 9 emulator, but I have no idea what's going on :(

peterbabic commented 3 years ago

Currently, I have been playing for around 4 days sporadically, but the first 2 days shown no bugs whatsoever. Once they started, they are quite common. So it could be that something happened to device, but still strange.

mimoguz commented 3 years ago

Quite strange yes.

mimoguz commented 3 years ago

I played the game a few times in an emulator running Android 9 while watching collections. So far, no problems, no duplication whatsoever. I'll add some more checks and try again, might be some obscure bug somewhere.

peterbabic commented 3 years ago

It happened after reinstall too.

mimoguz commented 3 years ago

Hi. Sorry for late response. I've made a few revisions and will put up a beta in a few days (When I'm better or too bored :D . I've got the virus unfortunately.) Though, I don't know if it will fix the issue, since I can't replicate.

peterbabic commented 3 years ago

No! Get out the bed, I need this business critical piece of software bug-free right now! And you rather respond to me right away next time!

Just kidding 😄 I mean, no need to excuse for "late responses". Remember, we are doing this for fun. And get well soon! 🙏🏻

xxxxme commented 3 years ago

I'm using 0.44 from F-Droid on Android 9 also. I got an extra 10 of hearts on the upper left. It flipped over when I drew the 10 of hearts from the draw pile, and at this point it could be taken as if it were uncovered. (I play with covered cards hidden.) Here's the original deal, with the extra 10 beside the first in the draw pile, since that's where it went when I hit undo. Screenshot_20210508-202759_TriPeaks Edit: It looks like it's replacing the king of spades.

mimoguz commented 3 years ago

Hi again.

I released a test version on the Google Play Store. Could you please try that? It will just crash if there are really duplicate cards.

Join testing program Play Store link

Thanks.

PS. I can create an apk if you want. Play Store test releases are signed and I assume checked tough, so should be safer than a random apk.

xxxxme commented 3 years ago

It would have to be an apk posted here or uploaded to f-droid, for me. I don't have a Google account, so I can't join the testing program.

mimoguz commented 3 years ago

Apks are here

izaleu commented 3 years ago

Just chiming in to say I've also experienced this issue, it started happening after an update but I can't remember which one 💀

mimoguz commented 3 years ago

Problem with this issue is I can't reproduce it at all! No updates except first a few and 0.46 touched the game mechanics, and 0.46 should have fixed only possible cause I could think. ☹

I guess at the end I will need to sit down and re-write entire view logic. I suck at programming. 😁

izaleu commented 3 years ago

Problem with this issue is I can't reproduce it at all! No updates except first a few and 0.46 touched the game mechanics, and 0.46 should have fixed only possible cause I could think. ☹

I guess at the end I will need to sit down and re-write entire view logic. I suck at programming. 😁

It's very hard to reproduce! I will definitely update if I get any more info.

mimoguz commented 3 years ago

Would you please check the 0.5 branch test release: tripeaks-test-releases/releases/tag/0.5b1

I rewrote most of the game logic and rendering parts, much simpler now. Are the problems still persist?

Thanks.

mimoguz commented 3 years ago

Since I couldn't get a response, I'm closing this issue for now.

peterbabic commented 3 years ago

@mimoguz Hello, I checked when you last wrote 0.5 is out, but at that time I could only get 0.4 something from F-Droid and forgot about it since.

mimoguz commented 3 years ago

No problem :) The new release should be on F-Droid sometime next week. Please let me know if the issue persists. Thanks.