search

mimoguz / tripeaks-gdx

A simple tri peaks solitaire game using libGDX.
GNU General Public License v3.0
68 stars 8 forks source link

Crashes on launch #8

Closed izaleu closed 3 years ago

izaleu commented 3 years ago

Updated to version 0.46 and the game fails to launch. 0.45 works fine.

Android v11 Pixel 3

alexfornuto commented 3 years ago

Same on OnePlus 9, Android 11.

elea11 commented 3 years ago

same here. the latest build also is only ~350KB in size whereas the previous ones had about 1.2MB.

mimoguz commented 3 years ago

the latest build also is only ~350KB in size whereas the previous ones had about 1.2MB.

350kB? There is something wrong with the f-droid build then. Let me investigate.

mimoguz commented 3 years ago

Yep, native libraries were missing in the apk. Turned out a gradle issue, updating the plugin fixed it. Creating a new release for the fix. Thanks!

quelbs commented 3 years ago

The F-droid build of 0.46.1 ist still 365kb in size, it still has the same issue.

mimoguz commented 3 years ago

Works on my machine!™ I probably messed up something else. That's the downside of not being able to control final build I guess (F-Droid build and package themselves). I will ask F-Droid people to take down 0.46+ if possible, and post apks here until the issue is resolved.

Thanks.

linsui commented 3 years ago

Is this the same issue as https://github.com/yairm210/Unciv/issues/3946?

mimoguz commented 3 years ago

Is this the same issue as yairm210/Unciv#3946?

Seems so. Build plug-in version 4.2.2 with Gradle 7.1.1 worked on my machine, but downgrading to the versions I used in last good release will be safer I guess. Will that be enough?

mimoguz commented 3 years ago

Or this (from Unciv)?

 if ("package" in name || "assemble" in name) {
     dependsOn("copyAndroidNatives")
 }
linsui commented 3 years ago

If this is the same issue you can reproduce the problem by building from scratch.

mimoguz commented 3 years ago

If this is the same issue you can reproduce the problem by building from scratch.

Hmm. Yes, I can reproduce if I delete the libs folder before build, even with the new versions. So the same issue.

mimoguz commented 3 years ago

Changed

if (packageTask.name.contains("package"))

to

if (packageTask.name.contains("package") || packageTask.name.contains("assemble"))

and now they are in the apk 🙂. I'll do a few more tests with different gradle wrapper/build plugin versions, just to be sure. Please let me know if there is more to this. Thanks.

mimoguz commented 3 years ago

0.46.2 is now on f-droid. Thank you all.