mimoralea / gdrl

Grokking Deep Reinforcement Learning
https://www.manning.com/books/grokking-deep-reinforcement-learning
BSD 3-Clause "New" or "Revised" License
812 stars 234 forks source link

Container must be run with group "root" to update passwd file #1

Closed franckalbinet closed 5 years ago

franckalbinet commented 5 years ago

Hi Miguel,

Thanks for today's update with the new fresh chapter 5. I am trying to install everything via Docker.

When running docker run -it --rm -p 8888:8888 -v "$PWD"/notebooks/:/mnt/notebooks/ mimoralea/gdrl:v0.7, then accessing Jupyter, the password you provided looks invalid.

Furthermore, the first line in the console line after running the container is:

Container must be run with group "root" to update passwd file

Am I missing something?

Thanks again

mimoralea commented 5 years ago

Hi, Franck.

I'm not sure what the problem would be. I just run the steps above, downloaded the image on a clean system, input the password gdrl and I'm able to access the chapters.

I wonder if the issue is that the repository was cloned with different group permissions?

Can you show me the permissions you have? Do your user and group seem to have the correct permissions?

± |master ✓| → ls -la notebooks/chapter_05
total 3200
drwxr-xr-x   3 mimoralea  staff       96 Feb 16 12:48 .
drwxr-xr-x  11 mimoralea  staff      352 Feb 16 12:48 ..
-rw-r--r--   1 mimoralea  staff  1635282 Feb 16 12:48 chapter-05.ipynb
franckalbinet commented 5 years ago

Thx for your quick reply!

I do have the same permissions as you:

ganesh:gdrl-official-repo franck$ ls -la notebooks/chapter_05                                    │
total 3200                                                                                       │
drwxr-xr-x   3 franck  staff      102 Feb 16 18:35 .                                             │
drwxr-xr-x  12 franck  staff      408 Feb 16 21:54 ..                                            │
-rw-r--r--   1 franck  staff  1635282 Feb 16 18:35 chapter-05.ipynb  

Just wanted to check with you in case I missed something obvious. I will continue investigating this issue after the we. Will keep you posted. Nothing urgent on my side.

Thx

franckalbinet commented 5 years ago

Simply stopped all other running Jupyter notebooks and that's it! Get access to your amazing notebooks now. Thanks. Sorry for the inconvenience.

mimoralea commented 5 years ago

Great! Thanks for the feedback, Franck. And no worries, feel free to open issues at any time.

yashGuleria commented 2 years ago

Hi @franckalbinet , @mimoralea , 3 years later, Im facing a similar problem. I have the permissions, No other notebook is open but still the the link for the jupyter notebook cannot be opened. Any suggestions? Screenshot from 2022-08-19 11-57-50 Screenshot from 2022-08-19 12-02-45

mimoralea commented 2 years ago

Does localhost:8888/ work for you?

yashGuleria commented 2 years ago

Hi ! while starting the container I ran it with " sudo docker" instead of just "docker run . . .. " . And yes localhost:8888 worked. Thank you . Regards

cbasile2 commented 2 years ago

Hi Miguel , do I need to write grld somewhere? I am currently doing

sudo docker run -it --rm -p 8888:8888 -v "$PWD"/notebooks/:/mnt/notebooks/ mimoralea/gdrl:v0.14

But, both the local , and nor the link generated worked. Should I replace PWD with grld? Thanks

mimoralea commented 2 years ago

PWD prints the working directory. gdrl is the password to access the notebook through the website. First, make sure you're running these commands from the right folder

cbasile2 commented 2 years ago

Hi Miguel ,

thanks. I am running from grld. Here is the terminal shots.

image

image

Thanks

cbasile2 commented 2 years ago

I run command from grld, and then it says is running , but when I go to local url I do not see it. Do I need to write grld password somewhere if I am running the terminal? I am new to docker. many thanks

mimoralea commented 2 years ago

Just open a browser and go to http://localhost:8888/ you will be asked for a password there. Don't kill the terminal session, you need it running while working.

Also notice it's gdrl, not grdl.

On Wed, Oct 26, 2022, 7:44 AM Christian D Basile @.***> wrote:

I run command from grld, and then it says is running , but when I go to local url I do not see it. Do I need to write grld password somewhere if I am running the terminal? I am new to docker. many thanks

— Reply to this email directly, view it on GitHub https://github.com/mimoralea/gdrl/issues/1#issuecomment-1291977463, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWJIBEWZEBHVGUGUYEAUJTWFERSFANCNFSM4GX4SODA . You are receiving this because you were mentioned.Message ID: @.***>

cbasile2 commented 2 years ago

Miguel, wow now it worked. I actually had a local anaconda running already, and when I shut down my anaconda instance locally , then it worked. it will be nice to find out a way to have both your book and my own instance, I will try it smoe time later, but thanks for the help appreciate it!!