search

mimoralea / gdrl

Grokking Deep Reinforcement Learning
https://www.manning.com/books/grokking-deep-reinforcement-learning
BSD 3-Clause "New" or "Revised" License
798 stars 231 forks source link

Cannot start the notebooks from the container #16

Closed Spampi626 closed 2 years ago

Spampi626 commented 2 years ago

Hi! First time opening an issue, hope to make it right. Not a super expert of using Docker and Windows command line in general, but I followed the instruction on the README. Basically, if I try to run the docker with the recommended command I get the error:

...\gdrl>docker run -it --rm -p 8888:8888 -v %CD%/notebooks/:/mnt/notebooks/ mimoralea/gdrl:v0.14
docker: invalid reference format: repository name must be lowercase.
See 'docker run --help'.

the same if I use %cd% instead of %CD%.

I really don't understand where the issue is, since apart from %CD% there is no a single upper case letter.

boyko11 commented 2 years ago

Hi @Spampi626, I'd try putting quotes around "%CD%/notebooks/:/mnt/notebooks/". If this doesn't help, I'd try putting the notebooks in a directory whose full path doesn't have any spaces or any upper case letters. If that doesn't help, there's various reasons for this error discussed here : https://stackoverflow.com/questions/48522615/docker-error-invalid-reference-format-repository-name-must-be-lowercase

On Sun, Nov 14, 2021, 1:28 PM Spampi626 @.***> wrote:

Hi! First time opening an issue, hope to make it write. Not a super expert of using Docker and Windows command line in general, but I followed the instruction on the README. Basically, if I try to run the docker with the recommended command I get the error:

...\gdrl>docker run -it --rm -p 8888:8888 -v %CD%/notebooks/:/mnt/notebooks/ mimoralea/gdrl:v0.14 docker: invalid reference format: repository name must be lowercase. See 'docker run --help'.

the same if I use %cd% instead of %CD%.

I really don't understand where the issue is, since apart from %CD% there is no a single upper case letter.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mimoralea/gdrl/issues/16, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADXR2UBEJYJVTNC64ZYHFLUL75VTANCNFSM5IAEGZLA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Spampi626 commented 2 years ago

Thank you @boyko11 ! I had a directory with a space, I renamed it and it worked. Actually I had to upload manually the notebooks once inside jupyter, but everything else worked fine.