"Spin up a container" correction

mimoralea / gdrl

Grokking Deep Reinforcement Learning

BSD 3-Clause "New" or "Revised" License

812 stars 234 forks source link

Closed wmeitzen closed 4 years ago

wmeitzen commented 4 years ago

In your main document (README.md) / "Running the code" / "Spin up a container" / on Windows:

docker run -it --rm -p 8888:8888 -v %cd%/notebooks/:/mnt/notebooks/ mimoralea/gdrl:v0.14

The %cd% should be capitalized. So, ...

docker run -it --rm -p 8888:8888 -v %CD%/notebooks/:/mnt/notebooks/ mimoralea/gdrl:v0.14

mimoralea commented 4 years ago

Thanks for this William. Do you want to contribute the pull request? I can't test it, but it makes sense.

wmeitzen commented 4 years ago

I'd rather not contribute at this time, thank you!

mimoralea commented 4 years ago

No worries. I made the change. Thanks for reporting.