minor fixes for KG scripts

mims-harvard / TDC

Therapeutics Commons: Artificial Intelligence Foundation for Therapeutic Science

https://tdcommons.ai

MIT License

957 stars 169 forks source link

minor fixes for KG scripts #255

Closed abearab closed 1 month ago

abearab commented 2 months ago

[x] fill scripts missed from PR #207
[x] fix and minor improvements in the KnowledgeGraph and PrimeKGDev classes
[x] write unit tests for primekg api, #266

abearab commented 2 months ago

@amva13 This PR is ready for your review, thanks! It mostly contains minor fixes missed in #207

amva13 commented 1 month ago

Hi @abearab wpuld yoh like to write unit tests for Primekg api? If so and they pass we can approve your changes to main primekg class.

Otherwise, I'll approve primekgdev soon.

abearab commented 1 month ago

Hi @amva13, I'll be happy to write unit tests and replace primekgdev with Primekg api.

amva13 commented 1 month ago

Ok great. You can make the changes in this PR and I'll review.

Sent from Proton Mail for iOS

On Wed, May 8, 2024 at 5:44 PM, Abolfazl (Abe) @.***(mailto:On Wed, May 8, 2024 at 5:44 PM, Abolfazl (Abe) < wrote:

Hi @.***(https://github.com/amva13), I'll be happy to write unit tests and replace primekgdev with Primekg api.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>