Closed malcolmgreaves closed 4 weeks ago
Hello! 👋
This PR enables downstream users to have greater compatibility with TDC's dependencies. Currently, it is difficult to use TDC as a dependency since its dependencies are pinned to specific versions. This PR allows for more flexibility by enabling any non breaking change version of a dependency to be used. This PR is motivated by a dependency version conflict that I'm encountering in my own project.
Since RDKit doesn't use Semantic Versioning 2.0, I manually looked through the release notes to determine that version 2024.3.1 is the first release after 2023.9.5 that introduces breaking changes.
@amva13 Not sure if you'd like me to include the version bump in this PR or not. Happy to make any changes :)
@malcolmgreaves, sorry for the delay. will review it in the next few days. TDC is submitting a paper.
Skimming it looks reasonable
No worries! Thanks for taking a look. Good luck on the submission 🤞
On Fri, Jun 7, 2024 at 1:18 PM Alejandro Velez Arce < @.***> wrote:
@malcolmgreaves https://github.com/malcolmgreaves, sorry for the delay. will review it in the next few days. TDC is submitting a paper.
Skimming it looks reasonable
— Reply to this email directly, view it on GitHub https://github.com/mims-harvard/TDC/pull/278#issuecomment-2155231386, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADUXUMSVWDLRX53SFVGPKTZGHTPLAVCNFSM6AAAAABIZCMVGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJVGIZTCMZYGY . You are receiving this because you were mentioned.Message ID: @.***>
hi @malcolmgreaves this is merged and new version released. Let me know if you still face any issues!
Thank you very much! 👏 I'll try it out today!
Loosens the requirements by establishing the current
==
as lower bounds (>=
) and uses the next major version update as an upper bound (<
).Bumps patch version to
0.4.17
too.