Gillis2014 paper does not corresponds to the 'xray' algorithm in SepNMF

mims-harvard / nimfa

Nimfa: Nonnegative matrix factorization in Python

http://ai.stanford.edu/~marinka/nimfa/

Other

542 stars 135 forks source link

Gillis2014 paper does not corresponds to the 'xray' algorithm in SepNMF #34

Closed liubenyuan closed 8 years ago

liubenyuan commented 8 years ago

Hi, thanks for this package.

I read gillis2014 paper entitled "Fast and Robust Recursive Algorithms for Separable Nonnegative Matrix Factorization" on IEEE PAMI. This article provides a spa alike algorithm, it does not give xray.

Where is this xray algorithm ? should the comment on sepnmf being updated.

Best.

marinkaz commented 8 years ago

@ismav, can you comment on this issue?

ismav commented 8 years ago

@marinkaz I believe in the comment we swapped XRAY with SPA. Is it possible to just swap to the correct order:

XRAY --- Kumar et al (2013) and SPA --- Gilles et al (2014).

marinkaz commented 8 years ago

Done. @ismav, thanks!