search

mimshwright / pixi-tagged-text

A component for pixi similar to Text that supports multiple styles in a single component as well as inline images.
MIT License
31 stars 14 forks source link

Support for v8? #424

Open mattevans-dev opened 6 months ago

mattevans-dev commented 6 months ago

Hi, This is a fantastic library! Now that Pixi has released v8, I was wondering if you had plans to support it in the future?

Thanks, Matt

mimshwright commented 5 months ago

I'm not doing much work on it these days but I support the idea to update it to the latest major version.

If anyone wants to do a PR I'd appreciate the help.

reececomo commented 5 months ago

Shortcut for later:

I think the main impact for this library will (obviously) be the changes to Sprite and Text - i.e. creating text, and sprites/text no longer have children. PIXI 8 is awesome performance improvements, ~but it'll be clunky transition~.

edit: actually after having a proper look – it shouldn't be too difficult

yunsii commented 2 months ago

I'm not doing much work on it these days but I support the idea to update it to the latest major version.

If anyone wants to do a PR I'd appreciate the help.

How about if I create a PR for it recently?

yunsii commented 2 months ago

I have to create a new repo https://github.com/yunsii/pixi-tagged-text-plus to support pixi.js v8, because of some strange bugs. The new repo using vite to develop and better DX.

It supported v8 already with 2 migrated demos only, and here has a verticle align defect to render inline images with demo 2, online demos: https://pixi-tagged-text-plus.vercel.app/demos

PR is welcome, and the defect seems not easy to handle 😂

yunsii commented 2 months ago

All demos has been migrated, and pixi.js v6 demos also deployed https://pixi-tagged-text-plus-git-pixi-v6-yuns-projects-7ce32866.vercel.app/demos?_vercel_share=SVRTebVS7Pktw3ZhP5VNhlzYjoIwBcKz

Some obvious defects (v6 vs v8):