search

mimugmail / opn-repo

OPNsense repo by mimugmail
Other
324 stars 24 forks source link

AdGuardHome: "restart" fails, while "start" works. #155

Open Qhilm opened 1 year ago

Qhilm commented 1 year ago

If I click on "restart" in the dashboard next to the AdGuardHome service, it fails, the service simply stops and never starts again. If I subsequently click "start", it starts properly.

Potential workaround: monit. But I am missing the start and stop commands for the service.

snapshotleisure commented 8 months ago

Hi, I am also facing this same issue

snapshotleisure commented 8 months ago

Hi, I have found a fix for this,

In the rc.d script located at /usr/local/etc/rc.d/adguardhome

Remove the line stop_cmd="killall AdGuardHome"

and everything works

I think the issue is the killall command is not reliable and its a fire and forget way to kill the process, so for a restart, it triggers the stop but doesnt wait for it to succeed before attempting the restart.

Removing it allows the normal stop process to trigger.

@mimugmail was there any reason the stop command was triggered that way? any chance the script can be updated with the next plugin update?

mimugmail commented 8 months ago

Sure, I can have a look

snapshotleisure commented 8 months ago

Thanks! Much appreciated