min-protocol / min

The MIN protocol specification and reference implementation
257 stars 88 forks source link

Possible bug in the code #45

Open subodh-malgonde opened 1 year ago

subodh-malgonde commented 1 year ago

I was just going through the Python code for the host. Found this line:

https://github.com/min-protocol/min/blob/9e87a791edb3757bee514672e98c3cbcd78f56a1/host/min.py#L557-L558

self._sn_max - self._sn_max will always be zero and the if condition will always evaluate to False.