mina-deploy / mina

Blazing fast deployer and server automation tool
https://rubygems.org/gems/mina
Other
4.35k stars 490 forks source link

Provide meaningful default shared folders #501

Closed jmuheim closed 7 years ago

jmuheim commented 7 years ago

I'm unsure which folders I should share. At the time being, it's the following:

set :shared_dirs, fetch(:shared_dirs, []).push('log', 'tmp', 'public/uploads')

Maybe you should provide meaningful default shared folders? Instead of

# set :shared_dirs, fetch(:shared_dirs, []).push('somedir')

something like

# set :shared_dirs, fetch(:shared_dirs, []).push('log', 'tmp', 'public/uploads')

because for shared files you already do provide meaningful default ones:

# set :shared_files, fetch(:shared_files, []).push('config/database.yml', 'config/secrets.yml')
arun057 commented 7 years ago

should probably include public/assets and vendor/bundle as well

d4be4st commented 7 years ago

@arun057 they are included by default

Will add to documentation