mina-deploy / mina

Blazing fast deployer and server automation tool
https://rubygems.org/gems/mina
Other
4.35k stars 490 forks source link

bundle:clean uses bundle_options which are not supported by latests bundlers #521

Closed Bounga closed 2 years ago

Bounga commented 7 years ago

According to this line https://github.com/mina-deploy/mina/blob/master/tasks/mina/bundler.rb#L19, bundler mina plugin try to use the same options for both bundleand clean tasks.

The issue is that bundle and clean doesn't allow the same options and that these options are validated before running the command so we end up with:

Unknown switches '--without, --path, --deployment'

when we try to use the clean task.

IMO the easiest fix is to ignore the options in clean task since there is no useful option for bundle clean command.