pump should always report non-zero discrepancy count

[GoogleCodeExporter]

distcc 3.2rc1 SVN r755

Pump should report any non-zero discrepancy count at the end, regardless of 
whether it triggered max_discrepancies_before_demotion.

Patch attached.

Original issue reported on code.google.com by kamal@whence.com on 4 Apr 2012 at 4:35

Attachments:

• pump-report-discrepancies.patch

[GoogleCodeExporter]

Pump is already reporting a warning for each such compilation:

Warning: remote compilation of '...' failed, retried locally and got a 
different result.

Do we really need an additional warning at the end?

Original comment by fergus.h...@gmail.com on 4 Apr 2012 at 6:38

[GoogleCodeExporter]

In my opinion, its quite useful to have the final discrepancy count presented 
at the end.  For a large build, its too easy to accidentally not notice a few 
discrepancy warnings buried in the log.  Having the tally presented at the end 
(if its not zero) makes it much more noticeable that something undesirable 
occurred.

Original comment by kamal@whence.com on 4 Apr 2012 at 6:46

[GoogleCodeExporter]

OK, sounds reasonable to me.

But if we're going to print this warning, then I think the message "See the 
Distcc Discrepancy Symptoms section in the include_server(1) man page." should 
be printed too, regardless of whether we hit max_discrepancies_before_demotion. 
 Can you update the patch to do that?

Original comment by fergus.h...@gmail.com on 4 Apr 2012 at 8:18

• Changed state: Accepted

[GoogleCodeExporter]

Agreed.  Will do.

Original comment by kamal@whence.com on 4 Apr 2012 at 8:25

[GoogleCodeExporter]

Fix applied as SVN r762.

Original comment by kamal@whence.com on 4 Apr 2012 at 8:46

• Changed state: Fixed